-
Type: Improvement
-
Resolution: Done
-
Priority: Major - P3
-
None
-
Affects Version/s: None
-
Component/s: Testing Infrastructure
-
None
-
DAG 2022-03-21, DAG 2022-04-04
-
2
It looks like attempting to specify any resmoke options to burn_in_tests.py requires including the python buildscripts/resmoke.py run incantation as well. From a Slack discussion it wasn't clear if this was intentional or not. We should either simplify how resmoke options are consumed so it isn't necessary or explicitly document how to specify additional arguments.
python buildscripts/burn_in_tests.py -- python buildscripts/resmoke.py run --dbpathPrefix /some/other/directory
Also note that the -- is necessary because the click command isn't being configured to ignored unrecognized arguments despite using click.UNPROCESSED. https://click.palletsprojects.com/en/latest/advanced/#forwarding-unknown-options
def _set_resmoke_cmd(repeat_config: RepeatConfig, resmoke_args: [str]) -> [str]: """Build the resmoke command, if a resmoke.py command wasn't passed in.""" new_args = [sys.executable, "buildscripts/resmoke.py", "run"] if resmoke_args: new_args = copy.deepcopy(resmoke_args)