Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-66917

InsertAndSeekKeyString unit test should use makeKeyStringForSeek

    • Type: Icon: Bug Bug
    • Resolution: Duplicate
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • ALL
    • Hide

      Apply the following patch (this comment from a ticket where the issue was first observed)

      --- a/src/third_party/wiredtiger/src/btree/bt_delete.c
      +++ b/src/third_party/wiredtiger/src/btree/bt_delete.c
      @@ -318,6 +318,9 @@ __wt_delete_page_instantiate(WT_SESSION_IMPL *session, WT_REF *ref)
           if (btree->modified)
               __wt_page_modify_set(session, page);
       
      +    /* Hack to get these fast deleted pages scheduled for eviction regularly */
      +    __wt_page_evict_soon(session, ref);
      +
           /* Allocate the per-page update array if one doesn't already exist. */
           if (page->entries != 0 && page->modify->mod_row_update == NULL)
               WT_PAGE_ALLOC_AND_SWAP(
      

      Run the unit test:

      ninja +storage_wiredtiger_record_store_and_index_test
      
      Show
      Apply the following patch ( this comment from a ticket where the issue was first observed) --- a/src/third_party/wiredtiger/src/btree/bt_delete.c +++ b/src/third_party/wiredtiger/src/btree/bt_delete.c @@ -318,6 +318,9 @@ __wt_delete_page_instantiate(WT_SESSION_IMPL *session, WT_REF *ref) if (btree->modified) __wt_page_modify_set(session, page); + /* Hack to get these fast deleted pages scheduled for eviction regularly */ + __wt_page_evict_soon(session, ref); + /* Allocate the per-page update array if one doesn't already exist. */ if (page->entries != 0 && page->modify->mod_row_update == NULL) WT_PAGE_ALLOC_AND_SWAP( Run the unit test: ninja +storage_wiredtiger_record_store_and_index_test
    • Execution Team 2022-06-27, Execution Team 2022-07-11, Execution Team 2022-07-25

      ..instead of makeKeyString. makeKeyStringForSeek includes the required discriminator. The lack of discriminator has been a source of failures in case of (by-design) variations in the order of entries returned by the WiredTiger cursor search_near API.

            Assignee:
            sulabh.mahajan@mongodb.com Sulabh Mahajan
            Reporter:
            josef.ahmad@mongodb.com Josef Ahmad
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: