Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-67268

Investigate simplifying usages of featureFlagXX, requires_fcv_xx and FeatureFlagUtil.isEnabled in JStests

    • Type: Icon: Task Task
    • Resolution: Duplicate
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • Replication

      The requires_fcv_5x and requires_fcv_60 can simply be removed

      The requires_fcv_61 tag should be replaced with the appropriate feature flag tag if the test depends on a specific feature flag

      Edit: We currently cannot actually stop using requires_fcv_yy since if we have a feature flag that is enabled, (either through running in an all feature flags variant, or through being enabled by default), and we have a test that tests this feature, the featureFlagXX tag would not prevent it from being run on sharding_multiversion, so we should be tagging it with requires_fcv_yy.
      The current guidance for feature flag test tagging is here, but it is slightly complicated, so we should investigate simplifying this. Additionally, we should investigate moving away from using FeatureFlagUtil.isEnabled where possible, since it is wasteful to start up a whole cluster only to see that the feature flag is not enabled and then skip the whole test.

            Assignee:
            backlog-server-repl [DO NOT USE] Backlog - Replication Team
            Reporter:
            huayu.ouyang@mongodb.com Huayu Ouyang
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: