-
Type:
Improvement
-
Resolution: Fixed
-
Priority:
Major - P3
-
Affects Version/s: None
-
Component/s: None
-
Replication
-
Fully Compatible
-
Repl 2023-04-03, Repl 2023-04-17, Repl 2023-05-01
SERVER-68868 intends to remove UninterruptipleLockGuard uses where possible, from its description:
Uses of UninterruptibleLockGuard indicate places in the code that do not comply with MongoDB's requirement that all operations be interruptible at places where they block to wait for resources. Every one of them is a potential future deadlock, and adds complexity to other parts of the codebase. We should reimplement codepaths that depend on UninterruptibleLockGuard so as to be interruptible.
The work has been split for the different teams in server, this one being for Replication.
SERVER-68867 introduced a linter rule to add friction when adding new UninterruptipleLockGuard instances, and commented existing ones with NOLINT, while also adding a TODO with the corresponding server team ticket if an instance was found to not have a comment explaining why its use is warranted.
We should either add a comment justifying the use of UninterruptibleLockGuard or fix the code to remove its use.
Search for "TODO (SERVER-71443)" in the code:
https://github.com/10gen/mongo/blob/34ac49477b87e183637f68cda828ecff8b393c64/src/mongo/db/repl/oplog_buffer_collection.cpp#L464
https://github.com/10gen/mongo/blob/34ac49477b87e183637f68cda828ecff8b393c64/src/mongo/db/repl/oplog_buffer_collection.cpp#L473
https://github.com/10gen/mongo/blob/34ac49477b87e183637f68cda828ecff8b393c64/src/mongo/db/repl/storage_interface_impl.cpp#L132
The following instances were initially categorised as StorEx, but should probably done by Replication:
https://github.com/10gen/mongo/blob/34ac49477b87e183637f68cda828ecff8b393c64/src/mongo/db/transaction/transaction_participant.cpp#L1603
https://github.com/10gen/mongo/blob/34ac49477b87e183637f68cda828ecff8b393c64/src/mongo/db/transaction/transaction_participant.cpp#L1891
- is depended on by
-
SERVER-68868 Remove all instances of UninterruptibleLockGuard
-
- Blocked
-