Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-80376

Remove cluster_commands_helpers' isShardedColl method

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 7.1.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Fully Compatible
    • Execution EMEA Team 2023-09-04
    • 120

      SERVER-78611 added an isShardedColl method to cluster_commands_helpers, which queries the configsvr metadata.

      This method has very deceiving stability guarantees and will very likely be misused.
      The original usage on collmod_coordinator was right in using it because it does have stability guarantees due to it being a ddl coordinator that is holding the DDL lock.
      The new usages on cluster_* commands do not have that stability. Also, given that those are router commands, which operate on a routing table, it is not necessary to use isShardedColl to figure out if the collection was sharded – the routing table itself already has that information.

            Assignee:
            miquel.munoz@mongodb.com Miquel Munoz (Inactive)
            Reporter:
            jordi.serra-torrens@mongodb.com Jordi Serra Torrens
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: