Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-88294

Audit references to shouldRecoverFromOplogAsStandalone and add checks for magic restore as needed

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Replication
    • Repl 2024-08-05

      During the magic restore process, the server is in a restore state, and we may want to branch behavior based on this. For older manual restores, we check this state based on the shouldRecoverFromOplogAsStandalone function. For example, we'll check this function to determine if we should relax index constraints.

      We should audit calls of this function throughout the codebase, examine what behavior we're changing based on if we're in a restore state. If the restore behavior is relevant to magic restore, we should also add a check for `storageGlobalParams.magicRestore`.

      For context, this came out of a passthrough failure where a PIT magic restore process was applying a createIndexes oplog entry, and hit this invariant, because we were not relaxing index constraints during magic restore.

            Assignee:
            sean.zimmerman@mongodb.com Sean Zimmerman
            Reporter:
            ali.mir@mongodb.com Ali Mir
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: