Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-88816

Break up WiredTigerRecordStore::_insertRecords()

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Storage Execution

      After SERVER-88523, WiredTigerRecordStore::_insertRecords() handles:

      • Inserting records (oplog entries) into the oplog
        • Additionally, it seems to be possible to insert oplog entries WITHOUT recordIds provided
      • Inserting records into collections with recordIdsReplicated:false - i.e. recordIds are not caller provided
      • Inserting records into collections with recordIdsReplicated:true - i.e. recordIds are caller provided

      As a result the function's control flow keeps branching and merging and it's hard to understand. We should break the function up to make it easier to understand.

      Note - SERVER-88375 exists to perform a proper cleanup of that code / other code as well. So we may want to defer this ticket until SERVER-88375 is done.

            Assignee:
            backlog-server-execution [DO NOT USE] Backlog - Storage Execution Team
            Reporter:
            vishnu.kaushik@mongodb.com Vishnu Kaushik
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: