Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-90421

Suppress mozjs compile warnings

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 8.1.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Integration
    • Fully Compatible
    • v8.0, v7.0

      After the update of mozjs/spidermonkey in SERVER-64574, building mozjs started emitting a large number of warnings. Presumably, we're okay with whatever the warnings are indicating to us, so we should suppress them as we do for other third party libraries. As it is now, compile logs are very noisy, and it can make finding actual issues more difficult.

      example warnings:

      src/third_party/mozjs/extract/js/src/frontend/ScopeBindingCache.h:183:32: warning: 'virtual js::frontend::BindingMap<JSAtom*>* js::frontend::ScopeBindingCache::createCacheFor(js::Scope*)' was hidden [-Woverloaded-virtual]
        183 |   virtual BindingMap<JSAtom*>* createCacheFor(Scope* ptr);
            |                                ^~~~~~~~~~~~~~
      In file included from src/third_party/mozjs/extract/js/src/vm/Caches.h:17,
                       from src/third_party/mozjs/extract/js/src/vm/Runtime.h:49,
                       from src/third_party/mozjs/extract/js/src/jit/PcScriptCache.h:12,
                       from src/third_party/mozjs/extract/js/src/vm/JSContext.h:22,
                       from src/third_party/mozjs/extract/js/src/irregexp/RegExpShim.h:38,
                       from src/third_party/mozjs/extract/js/src/irregexp/util/UnicodeShim.cpp:8,
                       from src/third_party/mozjs/platform/aarch64/linux/build/irregexp/Unified_cpp_js_src_irregexp2.cpp:2:
      
      

            Assignee:
            santiago.roche@mongodb.com Santiago Roche
            Reporter:
            patrick.freed@mongodb.com Patrick Freed
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: