Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-91470

clang-tidy checker suggesting mongo::Mutex shouldn't look through typedefs

    • Type: Icon: Bug Bug
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Server Programmability
    • ALL

      As can be seen in the attached image, when not using diagnostic latches you will get a warning even when using mongo::Mutex as suggested because in that mode it is just a typedef for stdx::mutex. This linter should only consider the type named, not how it is defined.

      Also, while in there, we should probably change it's text to just suggest Mutex since we shouldn't generally use the mongo:: prefix in our code.

            Assignee:
            Unassigned Unassigned
            Reporter:
            mathias@mongodb.com Mathias Stearn
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: