Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-92416

Fix or remove bugprone-assert-side-effect clang-tidy check

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Server Programmability

      This seems to be largely useless and a waste of cycles as currently configured. For one thing we don't use the plain assert macro, so if we want it to be useful, we should make it check for our dassert. We should also consider enabling CheckFunctionCalls since most side effects will be via non-const functions and methods.

            Assignee:
            Unassigned Unassigned
            Reporter:
            mathias@mongodb.com Mathias Stearn
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: