Print remaining time on testing-txn-retry machinery

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Fixed
    • Priority: Major - P3
    • 8.1.0-rc0
    • Affects Version/s: None
    • Component/s: Testing Infrastructure
    • None
    • Query Execution
    • Fully Compatible
    • 200
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None

      This is a suggestion to improve the debugging experience around failures raised by the txnRunCommandOverride functionality used on our testing infrastructure to retry upon transient transaction errors.

      These suggestions came up after debugging a couple of build failures caused by a txn error.

      For some context, the overridden method for retrying txn can stop for two reasons: either the number of retries has exceeded a limit or a timeout has expired.

      I found it not trivial to understand the timeout had expired by just looking at the logs, that's why I'm suggesting to improve the logging on the following points:

      • Print the remaining time on every retry as we do with the remaining attempts
      • Print a message when we stop retrying with the stopping reason and the last failure. This is especially interesting when the operation times out since it's confusing to see a number of remaining attempts bigger than 1 as the last retry without succeeding.

            Assignee:
            Jan Steemann
            Reporter:
            Silvia Surroca
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: