Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-94642

Make code ownership for IDL validator more fine-grained

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Minor - P4 Minor - P4
    • 8.1.0-rc0
    • Affects Version/s: None
    • Component/s: IDL, Internal Code
    • None
    • Query Execution
    • Fully Compatible
    • QE 2024-09-30

      As a part of SERVER-77400, we wanted to add code ownership for the IDL validation script (`buildscripts/idl/idl_check_compatibility.py`) to QO, as suggested on Slack:

      This is also suggested in the stable API readme.

      During review of the PR for SERVER-77400, it was suggested to leave code ownership for IDL validation script with server-programmability, but move the individual exceptions for APIs into separate files, which could be owned by the respective teams.
      The review comment suggesting this is https://github.com/10gen/mongo/pull/26111#pullrequestreview-2290095459.
      We agreed to do this as a follow-up to SERVER-77400, in order to unblock the original PR.

       

      The suggestion now is to move the separate arrays/lists from the IDL validation script into separate YAML files, which then could be owned by QO. The IDL validation script could then be owned by server-programmability.

        1. image-2024-09-09-21-40-47-640.png
          image-2024-09-09-21-40-47-640.png
          153 kB
        2. qo_ownership.png
          qo_ownership.png
          152 kB

            Assignee:
            jan.steemann@mongodb.com Jan Steemann
            Reporter:
            jan.steemann@mongodb.com Jan Steemann
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: