Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-94813

Consider changing WriteConcernFailed code name to WriteConcernTimedOut

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 8.1.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Replication
    • Minor Change
    • Repl 2024-09-30, Repl 2024-10-14, Repl 2024-10-28, Repl 2024-11-11, Repl 2024-11-25

      Almost all of the usages of WriteConcernFailed today are cases where waiting for write concern timed out. It's worth considering changing this code name to better reflect that.

      The only usage we found that isn't for a timeout purpose is on mongos where it is used to combine multiple write concern errors into one. That should maybe have its own error type or we should instead just return one of the errors instead of treating this case specially, in the spirit of this comment, regarding a similar situation where we return MultipleErrorsOccurred when we get multiple write errors.

      I believe drivers should only be checking error codes and labels, not error code names, so I don't think this would present an issue for them.

      See comment for some additional context from Slack discussion.

            Assignee:
            brad.cater@mongodb.com Brad Cater
            Reporter:
            kaitlin.mahar@mongodb.com Kaitlin Mahar
            Votes:
            0 Vote for this issue
            Watchers:
            12 Start watching this issue

              Created:
              Updated:
              Resolved: