Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-95380

Abstract away ThreadLifecycle object and get rid of the is_fsm_workload / use_action_permitted_file variable

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Correctness

      Currently some background hooks have a variable use_action_permitted_file that needs to be set whenever an FSM workload is being run (note that this variable will be renamed to is_fsm_workload in SERVER-95248) - this variable determines what kind of lifecycle object is used in the hook.

      When this variable isn't set in the suite's YAML file the result is that some tests become incompatible with the suite due to the hook running while the tests' setup() and teardown() methods are run.

      Since Resmoke already has all the information necessary to know whether a suite is a concurrency suite or not, we should have Resmoke tell the hooks which lifecycle object to use instead. By doing this engineers won't have to think about the various lifecycle types that exist and can't make errors.

      More context in comments.

            Assignee:
            Unassigned Unassigned
            Reporter:
            vishnu.kaushik@mongodb.com Vishnu Kaushik
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: