Uploaded image for project: 'VS Code Extension'
  1. VS Code Extension
  2. VSCODE-128

VSCode playground cancellation double checks

    • Type: Icon: Task Task
    • Resolution: Works as Designed
    • Priority: Icon: Major - P3 Major - P3
    • 0.0.1
    • Affects Version/s: None
    • Component/s: None
    • None

      Check how VSCode playground behaves in the following cases:

      1) We do not call `(serviceProvider as any)?.mongoClient.close(false)` after each runtime evaluation and after the cancelation of the runtime. We just terminate the whole worker thread. Since `worker.terminate()` stops the worker and all JavaScript execution in the worker thread probably it is enough

      2) When canceling a playground by `this._languageServerController.cancelAll()` if several playgrounds are open, whether or not they interfere with each other. We create a new Worker for every run of a playground. So it should be a new serviceProvider and mongoClient for each thread. Probably it should be fine.

       

      To reference: https://github.com/mongodb-js/vscode/pull/54

            Assignee:
            alena.khineika@mongodb.com Alena Khineika
            Reporter:
            alena.khineika@mongodb.com Alena Khineika
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: