-
Type: Task
-
Resolution: Gone away
-
Priority: Major - P3
-
Affects Version/s: None
-
Component/s: Tech debt
-
None
-
5
-
Not Needed
-
Iteration Orange
Recently vscode did a release which moved their credential storing native node module keytar to a new process: https://github.com/microsoft/vscode/issues/108342#issuecomment-706340396
https://code.visualstudio.com/updates/v1_50#_macos-keychain-access-moved-to-a-different-process
This results in our extension asking for keychain permissions for each stored connection. While this is something that needs to happen when the process accessing the keychain changes, we can change our usage of the credential store to store one key which is used to access or decrypt all of the connections. This will make it so that if something similar happens in the future, the usage of keytar changes, we can ask just once for access to the keychain instead of something that really hurts user experience.
- is cloned by
-
COMPASS-6854 Move from keytar to Electron safeStorage
- Closed
- related to
-
VSCODE-438 Investigate how to remove the keytar shim from our connection storing.
- Closed
- links to