Uploaded image for project: 'VS Code Extension'
  1. VS Code Extension
  2. VSCODE-184

Move from keytar to Electron safeStorage

    • Type: Icon: Task Task
    • Resolution: Gone away
    • Priority: Icon: Major - P3 Major - P3
    • No version
    • Affects Version/s: None
    • Component/s: Tech debt
    • None
    • 5
    • Not Needed
    • Iteration Orange

      Recently vscode did a release which moved their credential storing native node module keytar to a new process: https://github.com/microsoft/vscode/issues/108342#issuecomment-706340396 
      https://code.visualstudio.com/updates/v1_50#_macos-keychain-access-moved-to-a-different-process

      This results in our extension asking for keychain permissions for each stored connection. While this is something that needs to happen when the process accessing the keychain changes, we can change our usage of the credential store to store one key which is used to access or decrypt all of the connections. This will make it so that if something similar happens in the future, the usage of keytar changes, we can ask just once for access to the keychain instead of something that really hurts user experience.

            Assignee:
            Unassigned Unassigned
            Reporter:
            rhys.howell@mongodb.com Rhys Howell
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: