-
Type: Task
-
Resolution: Won't Fix
-
Priority: Minor - P4
-
Affects Version/s: None
-
Component/s: Tech debt
-
None
-
1
-
Not Needed
That's a rather large chunk of code with all errors (including builtins like TypeError) ignored. Probably best to just wrap specific things that might error like (usually) file operations and then only ignore specific errors and rethrow the rest. Generally best to leave unexpected errors to bubble up and either crash the process or get caught higher up because otherwise any programmer error (and not just network or filesystem type errors) could get swallowed and we'll never even know about it.
Or we could at least log the errors somewhere as a last resort.
It was suggested we do all these together so I'll link them all here and then close the others.
https://jira.mongodb.org/projects/VSCODE/issues/VSCODE-288?filter=allopenissues
https://jira.mongodb.org/projects/VSCODE/issues/VSCODE-290?filter=allopenissues
- related to
-
VSCODE-288 try {} catch {} used to wrap asynchronous event callbacks
- Closed
-
VSCODE-290 try {} catch {} used to wrap promise.then
- Closed