Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-11251

Avoid hardcoded values for failpoints

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • StorEng - Refinement Pipeline

      To reproduce WT-11242, we had to do the following changes:

      diff --git a/src/evict/evict_page.c b/src/evict/evict_page.c
      index 6d54acac4..8954b02ec 100644
      --- a/src/evict/evict_page.c
      +++ b/src/evict/evict_page.c
      @@ -277,7 +277,7 @@ __wt_evict(WT_SESSION_IMPL *session, WT_REF *ref, uint8_t previous_state, uint32
            * dead tree.
            */
           if (!closing && !tree_dead &&
      -      __wt_failpoint(session, WT_TIMING_STRESS_FAILPOINT_EVICTION_FAIL_AFTER_RECONCILIATION, 10)) {
      +      __wt_failpoint(session, WT_TIMING_STRESS_FAILPOINT_EVICTION_FAIL_AFTER_RECONCILIATION, 1000)) {
               ret = EBUSY;
               goto err;
           }
      

      We should be able to control that value through testing or randomise the value chosen.

            Assignee:
            backlog-server-storage-engines [DO NOT USE] Backlog - Storage Engines Team
            Reporter:
            etienne.petrel@mongodb.com Etienne Petrel
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: