Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-12253

statistics_log=(sources...) documentation and code don't match

    • Storage Engines
    • 2
    • 2024-02-06 tapioooooooooooooca, 2024-02-20_A_near-death_puffin, 2024-03-05 - Claronald, 2024-03-19 - PacificOcean, Megabat - 2024-05-14

      The documentation for statistics_log=(sources=...) uses table: and table:mytable as an example. This is what it says (in dist/api_data.py):

              if non-empty, include statistics for the list of data source URIs, if they are open at the
              time of the statistics logging. The list may include URIs matching a single data source
              ("table:mytable"), or a URI matching all data sources of a particular type ("table:")
      

      The code only allows file: and lsm: data sources (in conn/conn_stat.c:statlog_config:

              for (cnt = 0; (ret = __wt_config_next(&objectconf, &k, &v)) == 0; ++cnt) {
                  /*
                   * XXX Only allow "file:" and "lsm:" for now: "file:" works because it's been converted
                   * to data handles, "lsm:" works because we can easily walk the list of open LSM
                   * objects, even though it hasn't been converted.
                   */
                  if (!WT_PREFIX_MATCH(k.str, "file:") && !WT_PREFIX_MATCH(k.str, "lsm:"))
                      WT_ERR_MSG(session, EINVAL,
                        "statistics_log sources configuration only supports objects of type \"file\" or "
                        "\"lsm\"");
                  WT_ERR(__wt_strndup(session, k.str, k.len, &sources[cnt]));
              }
      

      Our testing only tests those allowed options in test/suite/test_reconfil01.py and test/suite/log02.py.

      The documentation should be updated to say currently only file: and lsm: sources are supported.

            Assignee:
            chenhao.qu@mongodb.com Chenhao Qu
            Reporter:
            sue.loverso@mongodb.com Susan LoVerso
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: