Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-12603

Convert chunkcache chunk valid flag to a bool

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Minor - P4 Minor - P4
    • WT11.3.0, 8.0.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • Storage Engines
    • 1
    • StorEng - Defined Pipeline

      Simple one line change, will enable some macro conversions in the future.

      uint32_t -> bool.

       ubuntu@ip-10-0-1-170:~/wiredtiger/build$ git diff ../src/include/block_chunkcache.h
      diff --git a/src/include/block_chunkcache.h b/src/include/block_chunkcache.h
      index 47193db0a..0cae141ae 100644
      --- a/src/include/block_chunkcache.h
      +++ b/src/include/block_chunkcache.h
      @@ -59,7 +59,7 @@ struct __wt_chunkcache_chunk {
           uint8_t *chunk_memory;
           wt_off_t chunk_offset;
           size_t chunk_size;
      -    wt_shared volatile uint32_t valid; /* Availability to read data from the chunk marked. */
      +    wt_shared volatile bool valid; /* Availability to read data from the chunk marked. */
      
       /* AUTOMATIC FLAG VALUE GENERATION START 0 */
       #define WT_CHUNK_FROM_METADATA 0x1u
      

      The variable is defined in the __wt_chunkcache_chunk struct.

            Assignee:
            andrew.morton@mongodb.com Andrew Morton
            Reporter:
            luke.pearson@mongodb.com Luke Pearson
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: