Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-13220

Improve error handling of invalid usage of wt verify dump_offsets command

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: Block Manager, Verify
    • Storage Engines
    • 2
    • StorEng - Defined Pipeline

      The following command runs but returns nothing:

      ./wt -h WT_TEST/test_hs01.0 verify -d dump_offsets= file:test_hs01.wt
      

      I think this is because an empty list is provided to dump_offsets. It would be better to let users know a valid list is expected.

      The next command fails without saying why:

      ./wt -h WT_TEST/test_hs01.0 verify -d dump_offsets file:test_hs01.wt 
      

      We should do a better job at handling the missing list from the dump_offsets arg and let users know it's an invalid command.

      Finally, we could improve the dump_offset setting description in api_data.py:

      diff --git a/dist/api_data.py b/dist/api_data.py
      index b18be86a3..bc82db374 100755
      --- a/dist/api_data.py
      +++ b/dist/api_data.py
      @@ -1722,8 +1722,8 @@ methods = {
               handler, intended for debugging; requires optional support from the block manager''',
               type='boolean'),
           Config('dump_offsets', '', r'''
      -        Display the contents of specific on-disk blocks, using the application's message handler,
      -        intended for debugging''',
      +        Display the contents of specific on-disk blocks at the specified offsets, using the
      +        application's message handler, intended for debugging''',
               type='list'),
           Config('dump_pages', 'false', r'''
               Display the contents of in-memory pages as they are verified, using the application's
      

            Assignee:
            backlog-server-storage-engines [DO NOT USE] Backlog - Storage Engines Team
            Reporter:
            etienne.petrel@mongodb.com Etienne Petrel
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: