-
Type: Improvement
-
Resolution: Unresolved
-
Priority: Major - P3
-
None
-
Affects Version/s: None
-
Component/s: Checkpoints
-
Storage Engines
-
StorEng - Defined Pipeline
In WT-12390 the checkpoint states were changed from explicit #define}}s to an {{enum. The change was simple but has repercussions on developer productivity and triaging FTDC.
While looking at a lot of FTDC, I was comparing the checkpoint progress state in t2. I could see it moving from one to other states. I saw that "state 4" was getting increasingly longer with each checkpoint in one run.
I went to look for exactly what checkpoint state 4 is and there is no way to determine it now that states are enum instead of defined. I had to visually/manually count from the top of the list. This is very error prone and could be very difficult to maintain going forward if one accidentally looks at a different codebase and a state has been added or removed.
I suggest WT goes back to using #define for that state especially given it is visible to all via statistics.