Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-13802

Make sure the names like __wt_MODULE_* belong to the correct module.

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: Not Applicable
    • None
    • Storage Engines
    • 3

      We have a fair amount of names (functions and structs) where the __wt_ or __wti_ prefix is followed by something that resembles a module name but the item doesn't belong to that module.

      As part of modularization effort, these names should be changed to avoid confusion and improve modularity.

      Here is the list of these items as of today:

      src/include/btmem.h:512:87:          Module [column]      of a top-level record   '__wt_col_rle'                          does not match the module of the file [btree].
      src/include/btmem.h:539:8:           Module [column]      of a top-level record   '__wt_col_var_repeat'                   does not match the module of the file [btree].
      src/include/btmem.h:549:8:           Module [column]      of a top-level record   '__wt_col_fix_tw_entry'                 does not match the module of the file [btree].
      src/include/btmem.h:560:8:           Module [column]      of a top-level record   '__wt_col_fix_tw'                       does not match the module of the file [btree].
      src/include/btmem.h:1763:8:          Module [column]      of a top-level record   '__wt_col_fix_auxiliary_header'         does not match the module of the file [btree].
      src/include/lsm.h:53:8:              Module [cursor]      of a top-level record   '__wt_cursor_lsm'                       does not match the module of the file [lsm].
      src/include/meta.h:111:8:            Module [block]       of a top-level record   '__wt_block_mods'                       does not match the module of the file [meta].
      src/include/meta.h:183:8:            Module [checkpoint]  of a top-level record   '__wt_ckpt_snapshot'                    does not match the module of the file [meta].
      src/include/session.h:74:16:         Module [cursor]      of a top-level record   '__wt_cursor_list'                      does not match the module of the file [session].
      src/include/stat.h:414:8:            Module [conn]        of a top-level record   '__wt_connection_stats'                 does not match the module of the file [stat].
      src/include/stat.h:1453:8:           Module [session]     of a top-level record   '__wt_session_stats'                    does not match the module of the file [stat].
      src/log/log.h:117:8:                 Module [txn]         of a top-level record   '__wt_txn_printlog_args'                does not match the module of the file [log].
      src/log/log_private.h:270:8:         Module [cursor]      of a top-level record   '__wt_cursor_log'                       does not match the module of the file [log].
      src/include/btree_inline.h:63:1:     Module [evict]       of a top-level function '__wt_evict_page_soon_check'            does not match the module of the file [btree].
      src/include/btree_inline.h:2215:1:   Module [cursor]      of a top-level function '__wt_btcur_bounds_early_exit'          does not match the module of the file [btree].
      src/include/btree_inline.h:2242:1:   Module [cursor]      of a top-level function '__wt_btcur_skip_page'                  does not match the module of the file [btree].
      src/include/cache_inline.h:124:1:    Module [session]     of a top-level function '__wt_session_can_wait'                 does not match the module of the file [evict].
      src/include/cursor_inline.h:16:23:   Module [stat]        of a top-level function '__wt_stat_usecs_hist_incr_opread'      does not match the module of the file [cursor].
      src/include/cursor_inline.h:17:3335: Module [stat]        of a top-level function '__wt_stat_usecs_hist_incr_opwrite'     does not match the module of the file [cursor].
      src/include/serial_inline.h:149:1:   Module [column]      of a top-level function '__wt_col_append_serial'                does not match the module of the file [btree].
      src/block/block_addr.c:333:1:        Module [checkpoint]  of a top-level function '__wti_ckpt_verbose'                    does not match the module of the file [block].
      src/block/block_read.c:16:1:         Module [block_cache] of a top-level function '__wt_bm_read'                          does not match the module of the file [block].
      src/block/block_read.c:106:1:        Module [block_cache] of a top-level function '__wt_bm_corrupt'                       does not match the module of the file [block].
      src/block_cache/block_io.c:15:23:    Module [stat]        of a top-level function '__wt_stat_compr_ratio_read_hist_incr'  does not match the module of the file [block_cache].
      src/block_cache/block_io.c:16:5199:  Module [stat]        of a top-level function '__wt_stat_compr_ratio_write_hist_incr' does not match the module of the file [block_cache].
      src/btree/bt_curnext.c:625:1:        Module [cursor]      of a top-level function '__wti_cursor_key_order_check'          does not match the module of the file [btree].
      src/btree/bt_curnext.c:644:1:        Module [cursor]      of a top-level function '__wt_cursor_key_order_init'            does not match the module of the file [btree].
      src/btree/bt_curnext.c:674:1:        Module [cursor]      of a top-level function '__wt_cursor_key_order_reset'           does not match the module of the file [btree].
      src/btree/bt_curnext.c:694:1:        Module [cursor]      of a top-level function '__wti_btcur_iterate_setup'             does not match the module of the file [btree].
      src/btree/bt_curnext.c:758:1:        Module [cursor]      of a top-level function '__wt_btcur_next'                       does not match the module of the file [btree].
      src/btree/bt_curprev.c:726:1:        Module [cursor]      of a top-level function '__wt_btcur_prev'                       does not match the module of the file [btree].
      src/btree/bt_cursor.c:489:1:         Module [cursor]      of a top-level function '__wti_cursor_valid'                    does not match the module of the file [btree].
      src/btree/bt_cursor.c:606:1:         Module [cursor]      of a top-level function '__wt_btcur_reset'                      does not match the module of the file [btree].
      src/btree/bt_cursor.c:629:1:         Module [cursor]      of a top-level function '__wt_btcur_search_prepared'            does not match the module of the file [btree].
      src/btree/bt_cursor.c:720:1:         Module [cursor]      of a top-level function '__wti_btcur_evict_reposition'          does not match the module of the file [btree].
      src/btree/bt_cursor.c:769:1:         Module [cursor]      of a top-level function '__wt_btcur_search'                     does not match the module of the file [btree].
      src/btree/bt_cursor.c:973:1:         Module [cursor]      of a top-level function '__wt_btcur_search_near'                does not match the module of the file [btree].
      src/btree/bt_cursor.c:1095:1:        Module [cursor]      of a top-level function '__wt_btcur_insert'                     does not match the module of the file [btree].
      src/btree/bt_cursor.c:1317:1:        Module [cursor]      of a top-level function '__wt_btcur_insert_check'               does not match the module of the file [btree].
      src/btree/bt_cursor.c:1364:1:        Module [cursor]      of a top-level function '__wt_btcur_remove'                     does not match the module of the file [btree].
      src/btree/bt_cursor.c:1794:1:        Module [cursor]      of a top-level function '__wt_btcur_modify'                     does not match the module of the file [btree].
      src/btree/bt_cursor.c:1888:1:        Module [cursor]      of a top-level function '__wt_btcur_reserve'                    does not match the module of the file [btree].
      src/btree/bt_cursor.c:1914:1:        Module [cursor]      of a top-level function '__wt_btcur_update'                     does not match the module of the file [btree].
      src/btree/bt_cursor.c:1939:1:        Module [cursor]      of a top-level function '__wt_btcur_compare'                    does not match the module of the file [btree].
      src/btree/bt_cursor.c:2012:1:        Module [cursor]      of a top-level function '__wt_btcur_equals'                     does not match the module of the file [btree].
      src/btree/bt_cursor.c:2046:1:        Module [cursor]      of a top-level function '__wt_cursor_truncate'                  does not match the module of the file [btree].
      src/btree/bt_cursor.c:2169:1:        Module [cursor]      of a top-level function '__wt_btcur_range_truncate'             does not match the module of the file [btree].
      src/btree/bt_cursor.c:2230:1:        Module [cursor]      of a top-level function '__wt_btcur_init'                       does not match the module of the file [btree].
      src/btree/bt_cursor.c:2243:1:        Module [cursor]      of a top-level function '__wt_btcur_open'                       does not match the module of the file [btree].
      src/btree/bt_cursor.c:2268:1:        Module [cursor]      of a top-level function '__wt_btcur_free_cached_memory'         does not match the module of the file [btree].
      src/btree/bt_cursor.c:2285:1:        Module [cursor]      of a top-level function '__wt_btcur_close'                      does not match the module of the file [btree].
      src/btree/bt_cursor.c:2314:1:        Module [cursor]      of a top-level function '__wti_btcur_bounds_position'           does not match the module of the file [btree].
      src/btree/bt_misc.c:41:1:            Module [cell]        of a top-level function '__wti_cell_type_string'                does not match the module of the file [btree].
      src/btree/bt_page.c:482:1:           Module [column]      of a top-level function '__wti_col_fix_read_auxheader'          does not match the module of the file [btree].
      src/btree/bt_random.c:508:1:         Module [cursor]      of a top-level function '__wt_btcur_next_random'                does not match the module of the file [btree].
      src/btree/bt_sync_obsolete.c:793:1:  Module [checkpoint]  of a top-level function '__wt_checkpoint_cleanup_create'        does not match the module of the file [btree].
      src/btree/bt_sync_obsolete.c:836:1:  Module [checkpoint]  of a top-level function '__wt_checkpoint_cleanup_destroy'       does not match the module of the file [btree].
      src/btree/bt_sync_obsolete.c:865:1:  Module [checkpoint]  of a top-level function '__wt_checkpoint_cleanup_trigger'       does not match the module of the file [btree].
      src/btree/bt_vrfy_dsk.c:1131:1:      Module [cell]        of a top-level function '__wti_cell_type_check'                 does not match the module of the file [btree].
      src/btree/col_modify.c:18:1:         Module [column]      of a top-level function '__wt_col_modify'                       does not match the module of the file [btree].
      src/btree/col_srch.c:61:1:           Module [column]      of a top-level function '__wt_col_search'                       does not match the module of the file [btree].
      src/call_log/call_log.c:17:1:        Module [conn]        of a top-level function '__wt_conn_call_log_setup'              does not match the module of the file [call_log].
      src/call_log/call_log.c:49:1:        Module [conn]        of a top-level function '__wt_conn_call_log_teardown'           does not match the module of the file [call_log].
      src/config/config_api.c:187:1:       Module [conn]        of a top-level function '__wt_conn_foc_discard'                 does not match the module of the file [config].
      src/config/config_def.c:4303:1:      Module [conn]        of a top-level function '__wt_conn_config_init'                 does not match the module of the file [config].
      src/config/config_def.c:4324:1:      Module [conn]        of a top-level function '__wt_conn_config_discard'              does not match the module of the file [config].
      src/config/config_def.c:4338:1:      Module [conn]        of a top-level function '__wt_conn_config_match'                does not match the module of the file [config].
      src/conn/conn_ckpt.c:168:1:          Module [checkpoint]  of a top-level function '__wti_checkpoint_server_create'        does not match the module of the file [conn].
      src/conn/conn_ckpt.c:199:1:          Module [checkpoint]  of a top-level function '__wti_checkpoint_server_destroy'       does not match the module of the file [conn].
      src/conn/conn_ckpt.c:234:1:          Module [checkpoint]  of a top-level function '__wt_checkpoint_signal'                does not match the module of the file [conn].
      src/conn/conn_tiered.c:490:1:        Module [tiered]      of a top-level function '__wti_tiered_storage_create'           does not match the module of the file [conn].
      src/conn/conn_tiered.c:528:1:        Module [tiered]      of a top-level function '__wti_tiered_storage_destroy'          does not match the module of the file [conn].
      src/log/log_auto.c:1862:1:           Module [txn]         of a top-level function '__wt_txn_op_printlog'                  does not match the module of the file [log].
      src/session/session_compact.c:382:1: Module [compact]     of a top-level function '__wt_compact_check_eligibility'        does not match the module of the file [session].
      src/txn/txn_ckpt.c:420:1:            Module [checkpoint]  of a top-level function '__wt_checkpoint_get_handles'           does not match the module of the file [txn].
      src/txn/txn_ckpt.c:637:1:            Module [checkpoint]  of a top-level function '__wt_checkpoint_progress'              does not match the module of the file [txn].
      src/txn/txn_ckpt.c:2258:1:           Module [checkpoint]  of a top-level function '__wt_checkpoint_tree_reconcile_update' does not match the module of the file [txn].
      src/txn/txn_ckpt.c:2638:1:           Module [checkpoint]  of a top-level function '__wt_checkpoint_sync'                  does not match the module of the file [txn].
      src/txn/txn_ckpt.c:2662:1:           Module [checkpoint]  of a top-level function '__wt_checkpoint_close'                 does not match the module of the file [txn].
      

            Assignee:
            backlog-server-storage-engines [DO NOT USE] Backlog - Storage Engines Team
            Reporter:
            y.ershov@mongodb.com Yury Ershov
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: