-
Type:
Bug
-
Resolution: Fixed
-
Priority:
Minor - P4
-
Affects Version/s: None
-
Component/s: Cache and Eviction
-
Storage Engines
-
1
-
StorEng - 2025-03-14
The log when trying to set the eviction_updates_trigger configuration to 0 incorrectly states we set the default value to half of the eviction_updates_trigger value instead of the eviction_dirty_trigger.
if (evict->eviction_updates_trigger < DBL_EPSILON) { WT_CONFIG_DEBUG(session, "config eviction_updates_trigger (%f) cannot be zero. Setting " "to 50%% of eviction_updates_trigger (%f).", evict->eviction_updates_trigger, evict->eviction_dirty_trigger / 2); evict->eviction_updates_trigger = evict->eviction_dirty_trigger / 2; }
EDIT
1. I found a similar error in the same function in evict_conn.c, the error message should say setting to 50% of eviction_dirty_target not eviction_updates_target. This has also been fixed.
if (evict->eviction_updates_target < DBL_EPSILON) { WT_CONFIG_DEBUG(session, "config eviction_updates_target (%f) cannot be zero. Setting " "to 50%% of eviction_updates_target (%f).", evict->eviction_updates_target, evict->eviction_dirty_target / 2); evict->eviction_updates_target = evict->eviction_dirty_target / 2; }
2. Fixed pattern matching error in test_config12.py
Definition of Done:
- Goal 1: Make changes to debug msg to reflect the correct metric.
- Goal 2: Fix all inconsistencies in the __evict_validate_config function logs
- Goal 3: Fix pattern matching in test_config12