Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-9438

Skip cppsuite files in s_string

    • Storage Engines
    • 2
    • Storage - Ra 2022-06-13

       

      Summary
      Our script s_string does not support camelCase and reports lots of false positives from the cppsuite after WT-9385. This is temporary and will be resolved through WT-9433.

      Motivation

      • Does this affect any team outside of WT?
        No
      • How likely is it that this use case or problem will occur?
        We cannot use camelCase for the cppsuite files which prevents us from following the coding guidelines.
      • If the problem does occur, what are the consequences and how severe are they?
        Blocking WT-9385.
      • Is this issue urgent?
        No

      Acceptance Criteria (Definition of Done)
      s_script should ignore the test/cppsuite folder.

      [Optional] Suggested Solution

      diff --git a/dist/s_string b/dist/s_string
      index 1de04dda7..e1864f58e 100755
      --- a/dist/s_string
      +++ b/dist/s_string
      @@ -46,8 +46,8 @@ check() {
       
       # List of files to spellchk.
       l=`(cd .. &&
      -    find bench examples ext src test -name '*.[chsy]' &&
      -    find src -name '*.in' && find test -name '*.cxx' && find test -name '*.cpp')`
      +    find bench examples ext src test -not -path "test/cppsuite/*" -name '*.[chsy]' &&
      +    find src -name '*.in' && find test -name '*.cxx' && find test -not -path "test/cppsuite/*" -name '*.cpp')`
      

            Assignee:
            etienne.petrel@mongodb.com Etienne Petrel
            Reporter:
            etienne.petrel@mongodb.com Etienne Petrel
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: