Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-9605

Make test_salvage01 more robust for FLCS

    • Type: Icon: Technical Debt Technical Debt
    • Resolution: Fixed
    • Priority: Icon: Minor - P4 Minor - P4
    • 6.1.0-rc0, WT11.1.0
    • Affects Version/s: None
    • Component/s: None

      Currently test_salvage01 (and test_encrypt07, which reuses it) performs intentional data corruption by searching for a single row value in the on-disk file. This is fine for VLCS and row-store where the values are strings, but for FLCS a single value is a single byte and this is highly prone to matching in the wrong place; and sometimes in that case the corruption is unsalvageable (e.g. root page bad) and the test fails.

      This finally broke on me today, so I decided it was time to deal with it.

      I've fixed it so that in FLCS it searches to search for a sequence of bytes in adjacent rows. This still can break arbitrarily (if the sequence ends up spanning a page boundary, we won't be able to find it) but it's far less likely to.

            Assignee:
            backlog-server-storage-engines [DO NOT USE] Backlog - Storage Engines Team
            Reporter:
            dholland+wt@sauclovia.org David Holland
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: