Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-90641

Ensure IDL-defined commands use same request parsing codepath

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: IDL
    • None
    • Server Programmability

      SERVER-85791 introduced a few new helper functions that commands should use to parse their command requests, since it ensures that apiStrict is validated properly. Not all commands use this path though, in particular ones that don't perform apiStrict validation. We may want to add more command-generic parsing functionality like apiStrict validation in the future, so we should ensure all commands go through this common command request parsing path.

      We could help enforce this by changing the methods that the IDL-compiler generates for commands (e.g. making them private with only a specific class being a friend will ensure only that path can be used).

      Alternatively, if we update all commands to use TypedCommand (SERVER-91373) or BasicCommandWithRequestParser (SERVER-53890), we will get this as part of that. They aren't strictly necessary in order for this though.

            Assignee:
            Unassigned Unassigned
            Reporter:
            patrick.freed@mongodb.com Patrick Freed
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated: