Loading...

XML

Word

Printable

JSON

Type: Improvement
Resolution: Fixed
Priority: Major - P3
Fix Version/s: 8.1.0-rc0
Affects Version/s: None
Component/s: IDL
Labels:

Assigned Teams:

Service Arch
Backwards Compatibility:
Fully Compatible
Backport Requested:

v8.0
Sprint:
Service Arch 2024-02-05, Service Arch 2024-02-19, Service Arch 2024-03-04, Service Arch 2024-03-18, Service Arch 2024-04-01, Service Arch 2024-04-15, Service Arch 2024-04-29, Networking & Obs 2024-05-27, Networking & Obs 2024-06-10, Networking & Obs 2024-06-24
Linked BF Score:
200

After ~~SERVER-80296~~ is complete, the number of times the command request BSON is parsed on the command processing path will have greatly reduced. However, even after those changes, each command will still need to perform at least two parses: one for the common args (as consolidated in ~~SERVER-80296~~) and one for the command-specific fields (often an IDL-generated parse). We should move the latter parsing up earlier in the processing path so that we can combine it with the common argument parsing into a single pass, hopefully improving performance.

Some commands may still do parsing in multiple steps to allow for early exiting or to distribute the work involved in the parsing (e.g. aggregations may do this with the pipeline), but such cases should not need to walk over the entire request BSON for the subsequent passes.

This work will also be useful for PM-3613, which needs to inspect command requests in order to determine queuing priority. Moving the parsing step earlier as suggested above allows for such inspections to neither introduce an extra parsing step (which would hurt performance) nor rely on workarounds that could be a bit messy.

causes

SERVER-91711 getAuditConfigGeneration command does not filter request before passing through to shards

Closed

depends on

SERVER-42057 IDL option to generate chained setters

Closed

SERVER-88214 Add types to generic_argument.idl

Closed

SERVER-89351 Combine generic argument structs

Closed

is related to

SERVER-80296 Refactor command request processing path to reduce BSON parsing passes

Closed

SERVER-91169 Automatically chain generic reply fields to IDL structs marked as command replies

Open

SERVER-90641 Ensure IDL-defined commands use same request parsing codepath

Backlog

SERVER-91168 Accept command struct arguments instead of BSONObjs in internal transaction API

Backlog

SERVER-91316 Accept command struct arguments instead of BSONObjs in Shard API

Backlog

SERVER-91317 Manipulate IDL-generated structs instead of BSONObjs in TransactionRouter

Backlog

SERVER-88205 Eliminate redundant $db parses on common command paths

Closed

SERVER-90666 Ensure cluster find command parsing occurs in ClusterFindCmdBase::parse

Closed

SERVER-90823 Replace usages of BSON-manipulating generic argument helper functions with generic_argument_util equivalents

Closed

related to

SERVER-88604 Add more common request arguments

Closed

(8 is related to, 1 related to)

Assignee:: Patrick Freed

Reporter:: Patrick Freed

Participants:: Githook User, Patrick Freed, PM Bot

Votes:: 0 Vote for this issue

Watchers:: 14 Start watching this issue

Created:: Jan 26 2024 05:31:39 PM UTC

Updated:: Jul 16 2024 03:11:46 AM UTC

Resolved:: Jun 13 2024 02:59:37 PM UTC

Details

Description

Attachments

Issue Links

Activity

People

Dates