Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-90666

Ensure cluster find command parsing occurs in ClusterFindCmdBase::parse

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 8.1.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Service Arch
    • Fully Compatible
    • Networking & Obs 2024-07-08, Networking & Obs 2024-07-22, Networking & Obs 2024-08-05, Networking & Obs 2024-08-19, N&O Needs Merge

      ClusterFindCmdBase::parse does not actually parse the command request, and instead that work is deferred until the command invocation is run, which is unexpected. Deferring parsing will have also a performance cost once SERVER-85791 is merged, since the generic arguments need to be parsed in parse, so deferring will result in them being parsed twice.

      We should update ClusterFindCmd's implementation to actually parse the request in its parse method. The shard's implementation of find has already been updated to do this in SERVER-86084, so this will also make the two command implementations more consistent.

            Assignee:
            joseph.prince@mongodb.com Joseph Prince
            Reporter:
            patrick.freed@mongodb.com Patrick Freed
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: